On 9/28/2007 11:36 AM, Jan Wieck wrote:
> On 9/28/2007 10:33 AM, Marko Kreen wrote:
>> On 9/28/07, Tom Lane <tgl at sss.pgh.pa.us> wrote:
>>> "Marko Kreen" <markokr at gmail.com> writes:
>>> > bool          txid_not_visible_in_snapshot(int8, snap)
>>>
>>> The last seems pretty thoroughly redundant?
>> =

>> Ehhee.  Jan, it's 2:1 now.  I also think it unecessary.
> =

> Yeah, yeah ... I can live without it. It's just, from that point of view =

> half of all comparison operators are redundant ;-)
> =

>> =

>>> > - removed use of "unsigned long long" in txid_snapshot_out,
>>> >   instead I try to guess the correct fromat string for uint64
>>> >   from HAVE_LONG_INT_64
>>>
>>> What's to guess?  Use UINT64_FORMAT
>> =

>> Thanks, I failed to notice it for some reason.
>> =

>> New patch attached, both things fixed.
> =

> I'll look at it later today, if I find a free minute to breathe!

Well, found some time today. I have not checked the module by using it =

in Slony yet. I'll have some quiet 3 hours later. But I made a couple of =

changes as follows:

   - Adjusted Copyright to 2003-2007

   - Renamed USE_BSEARCH_IF_MORE to USE_BSEARCH_IF_NXIP_GREATER

   - Compare nxip > ...NXIP_GREATER (instead of >=3D)

   - Removed #ifndef SET_VARSIZE (must have been xxid artifact for
     pre-8.3 compatibility)

   - Removed qsort() wrapper function. Only referenced once.

   - Don't sort the xip vector if bsearch is never used on it.

   - Use $(MAKE) in Makefile to invoke installcheck (FreeBSD's make is
     not gmake).

Question:

   - Should we also move the txid_snapshot parsing functionality directly
     into the public function? Like the qsort wrapper, it is only used
     once throughout the code and a non-inline function call is not a
     zero-cost operation.

Other than that this looks good to me. Curious how Slony will like it.

New patch txid-v3.diff.gz attached.


Jan

-- =

#=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D JanWieck at Yahoo.com #
-------------- next part --------------
A non-text attachment was scrubbed...
Name: txid-v3.diff.gz
Type: application/x-gzip
Size: 6677 bytes
Desc: not available
Url : http://lists.slony.info/pipermail/slony1-hackers/attachments/20070930=
/72226db4/txid-v3.diff.bin