http://www.slony.info/bugzilla/show_bug.cgi?id=156

--- Comment #5 from Steve Singer <ssinger at ca.afilias.info> 2010-11-03 07:22:28 PDT ---

The latest version of the patch seems to introduce the following compiler
warning

slon.c: In function ‘SlonMain’:
slon.c:460: warning: comparison between pointer and integer

from the line 
if (PQgetvalue(res, 0, 0) == 'f') {
                slon_log(SLON_FATAL, 
                 "slon_node_health_check

I am surprised that your testing was able to get this warning to show up.

PQgetvalue(..) will return  a char * to a null terminated string not a char.
strncmp is probably what we want to be using.

2.  If I modify the code to work around that issue this is all I see when I see
in the slon output.

2010-11-03 10:19:30 EDTCONFIG main: local node id = 1
2010-11-03 10:19:30 EDTFATAL  could not call slon_node_health_check() -
2010-11-03 10:19:30 EDTCONFIG slon: child terminated status: 9; pid: 31474,
current worker pid: 31474
2010-11-03 10:19:30 EDTINFO   slon: done
2010-11-03 10:19:30 EDTINFO   slon: exit(0)


I'm not seeing the details. (ie the specific table that is the issue)

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.