On 7/9/2010 9:21 AM, Steve Singer wrote:
> Steve Singer wrote:
> 
> Attached is a revised version of the patch updated after I talked to Jan 
> about it.  Instead we just call rtcfg_enableNode() from the CLONE_NODE 
> processing block.
> 
> In my testing I am noticing that after a CLONE FINISH I sometimes get 
> duplicate key violations trying to insert into sl_event, (I also see 
> these with CLONE FINISH without the patch).  I'm thinking that is due to 
> another issue with clone node not bug120.

Me thinks this would possibly be a slightly too old sl_confirm, 
resulting in the clone trying to apply events that the source had 
already processed again.

This would very much depend on how the clone was actually created. 
Assume you create a clone of node 2 as node 3. If there is a gap between 
the prepare clone and when the actual copy is made, a running slon for 
node 2 has time to process more events. IIRC it is the clone preparation 
that creates the configuration copy including the content of sl_confirm.

Can you make sure that in your tests you stop the slon before doing the 
clone prepare and restart it only after the pg_dump transaction for the 
cloning has taken its snapshot?


Jan

> 
>> The attached patch tries to fix bug # 120.
>> 
>> As it is longer than a trivial patch someone else should look it over 
>> before I apply it.
>> 
>> Thanks
>> 
>> http://github.com/ssinger/slony/commit/c36394565260d751a493abdfa2b61fb90f2912b3 
>> 
>> 
>> 
>> 
>> ------------------------------------------------------------------------
>> 
>> _______________________________________________
>> Slony1-patches mailing list
>> Slony1-patches at lists.slony.info
>> http://lists.slony.info/mailman/listinfo/slony1-patches
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Slony1-patches mailing list
> Slony1-patches at lists.slony.info
> http://lists.slony.info/mailman/listinfo/slony1-patches


-- 
Anyone who trades liberty for security deserves neither
liberty nor security. -- Benjamin Franklin