On 12-11-12 10:28 AM, Devrim GÜNDÜZ wrote:
>
> Hi,
>
> On Mon, 2012-11-12 at 15:11 +0000, Luiz K.Matsumura wrote:
>> Change get_pid to return the smallest pid
>>
>> get_pid changed to return the smallest pid of processes that match
>> the regex, probably the main proccess
>
> Uh? You changed a behavior based on something "probably"?

One of the downsides to the 'keep the git history' approach of merging 
commits is that some of the intermediate states+commit comments don't 
actually reflect what finally got accepted/committed.

Chris and myself actually picked up on that during the review.  get_pid 
now uses the pid files slon generates instead of 'probably guessing the 
correct pid'.

http://git.postgresql.org/gitweb/?p=slony1-engine.git;a=commit;h=e1c8a5fc8d0ecec48bd87617b37cfa77e2899159
http://git.postgresql.org/gitweb/?p=slony1-engine.git;a=commit;h=3aa0abf7aec1fc2623ed2b97b4dea3fb200f51e9

But the fact that your paying attention brought a smile to my face. 
Feel free to point out any other potential issues you see with these 
patches.



>
> Regards,
>
>
>
> _______________________________________________
> Slony1-hackers mailing list
> Slony1-hackers at lists.slony.info
> http://lists.slony.info/mailman/listinfo/slony1-hackers
>