On 11-11-04 04:02 PM, Christopher Browne wrote:
> I'm in process of revisiting bug #137 in view of COPY protocol, and
> hitting a few issues worthy of asking things a bit broadly...
>
> I'm adding a new table to capture DDL, as per the discussions with Jan/Steve.
>
> Now, the _normal_ schema for this would be something like:
>
> create table @NAMESPACE at .sl_ddl (
> 	ddl_origin			int4,
> 	ddl_txid			bigint,
> 	ddl_actionseq		int8,
> 	ddl_query			text
> ) WITHOUT OIDS;
>
> Alas, there are parts of the log queries that use "log_txid" and
> "log_actionseq" to generate chunks of queries that I'd really like to
> use, and not regenerate from scratch.
>
> To readily do that, I need to rename 2 of the columns to conform with
> the names on sl_log_1/sl_log_2, thus:
>
> create table @NAMESPACE at .sl_ddl (
> 	ddl_origin			int4,
> 	log_txid			bigint,
> 	log_actionseq		int8,
> 	ddl_query			text
> ) WITHOUT OIDS;
>
> Is this a horrible inconsistency that I ought to rectify?  Or shall we
> not lose too much sleep over this?

Does this seem cleaner?

create table @NAMESPACE at .sl_log_ddl (
	log_origin			int4,
  	log_txid			bigint,
  	log_actionseq		int8,
  	log_query			text
  ) WITHOUT OIDS;

as a side note:

My current name for the log like table used on a log shipping receiver is

create table $clname.sl_log_archive (
	log_origin			int4,
	log_txid			bigint,
	log_tableid			int4,
	log_actionseq		int8,
	log_tablenspname	text,
	log_tablerelname	text,
	log_cmdtype			char,
	log_cmdupdncols		int4,
	log_cmdargs			text[]
) WITHOUT OIDS;

(This table will be the target of a COPY .. FROM STDIN but will have 
triggers on it that always return NULL so it won't never contain data). 
  See 
https://github.com/ssinger/slony1-engine/tree/copy-protocol_22_remoteworker 
for more details.


The sl_log_XXXXX convention seems to avoid your naming inconsistency and 
give some consistency to these various log tables we are creating.  I am 
also not too attached to these names if you have better ideas.



> _______________________________________________
> Slony1-hackers mailing list
> Slony1-hackers at lists.slony.info
> http://lists.slony.info/mailman/listinfo/slony1-hackers