Devrim GÜNDÜZ wrote:
> I just finished slon_ctl.pl script, which simply starts, stops and also
> checks status of slon daemon(s). It is attached.
> 
> Usage: slon_ctl [--config file] [start | stop | status ]
>        [--watchdog | --nowatchdog] [--sleep seconds] [node#]
> 
> It is mostly a copy-paste from slon_start, slon_stop and slon_status
> scripts.
> 
> I'm not a Perl guy, so I'll be happy if someone checks the code and
> functionality.

perl slon_ctl --config slon_tools.ssinger.conf start node1
works

perl slon_ctl --config slon_tools.ssinger.conf status node1
Mode: status

There is no such node.


perl slon_ctl --config slon_tools.ssinger.conf stop node1
Mode: stop

Usage: slon_ctl [--config file] [start | stop | status ]



So start works, but stop and status don't


What is the plan for the slon_start and slon_kill perl scripts, I'd like 
to see a big more code reuse between them (unless the plan is to replace 
them, but I am not sure how well that will go over with people that 
actually use the perl tools)

On the perl style side, I'd prefer to see perl code that works with 'use 
strict' (ie declares variables).  I also don't like using the global 
scope ie shutoff_processes could return $found instead of changing 
variable defined outside the function)





> 
> Regards,
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Slony1-hackers mailing list
> Slony1-hackers at lists.slony.info
> http://lists.slony.info/mailman/listinfo/slony1-hackers


-- 
Steve Singer
Afilias Canada
Data Services Developer
416-673-1142