Steve Singer <ssinger at ca.afilias.info> writes:
> The goal of this change is to make it easier to add tables to slony.  A 
> very common use-case is to want to add all your tables to a single slony 
> replication set.  Variations on that theme include 'all the tables in a 
> schema' or 'all the tables except these'.

I have set up a bug to track this feature
<http://www.slony.info/bugzilla/show_bug.cgi?id=181>

I don't see anything here to notably disagree with.

There are quite a few edge cases; I would suggest that the regression
tests include the following scenarios:

 a) Have a schema with NO tables that would be matched by the regex

    That'll lead to no tables being added, which isn't an error, right?

 b) Make sure there are some pathological-ish table names to be
    captured/excluded, including:

     - Names/schemas with spaces

     - Upper + lower case mixtures

     - Names containing special-ish characters including
           :-.()'"[]

  c) What happens if some tables are already replicated?

     Probably they should get ignored.  Perhaps slonik should output a
     warning in such cases?

  d) Try a bit of torture to come close to having table IDs getting
     reused.

     Given your protocol for locking nodes, this should fail gracefully.
-- 
output = ("cbbrowne" "@" "afilias.info")
Christopher Browne
"Bother,"  said Pooh,  "Eeyore, ready  two photon  torpedoes  and lock
phasers on the Heffalump, Piglet, meet me in transporter room three"