Devrim GÜNDÜZ <devrim at gunduz.org> writes:
> I cannot build man pages on any distro < Fedora 10, including RHEL 5.
> Here is the exact message:
>
> for file in  ; do \
> 	  /bin/sh /home/devrim/rpm/BUILD/slony1-2.0.0/config/install-sh -c -m 644 $file /var/tmp/slony1-2.0.0-3.f10-root-devrim/usr/share/doc/slony1-2.0.0/sgml || exit; \
> 	done
> for file in man1/slon.1 man1/slonik.1 ; do \
> 	   /bin/sh /home/devrim/rpm/BUILD/slony1-2.0.0/config/install-sh -c -m 644 $file /var/tmp/slony1-2.0.0-3.f10-root-devrim/usr/share/man/man1 || exit;\
> 	done

The problem is in having a loop there altogether, installing the man
pages one by one.

Make expands the names, and since many have spaces in them, that
breaks it.

I was going to say that there's nothing quite analagous in the
PostgreSQL documentation build, but I just wasn't looking hard enough
:-(.

I do find a difference...

PostgreSQL does:

	for file in man1/*.1 man$(sqlmansectnum)/*.$(sqlmansect) ; do \
	  $(INSTALL_DATA) $$file $(DESTDIR)$(mandir)/$$file || exit; \
	done

when the Slony-I build does:

	for file in $(wildcard man1/*) ; do \
	   $(INSTALL_DATA) $$file $(DESTDIR)$(mandir)/man1 || exit;\
	done

I'm thinking we should instead do...

	for file in man1/*.1; do \
	   $(INSTALL_DATA) $$file $(DESTDIR)$(mandir)/man1/$$file || exit;\
	done
	for file in man7/*.7; do \
	   $(INSTALL_DATA) $$file $(DESTDIR)$(mandir)/man7/$$file || exit;\
	done

Oddly, that breaks, complaining when it hits the first man page that
contains a space in its name, but if I augment it fairly trivially, as
follows, it works:

	for file in man1/*.1; do \
	   $(INSTALL_DATA) $$file $(DESTDIR)$(mandir)/man1/$$file || exit;\
	done
	for file in man7/*.7; do \
           echo $$file \
	   $(INSTALL_DATA) $$file $(DESTDIR)$(mandir)/man7/$$file || exit;\
	done

I'll CC Peter, in case he has any thoughts, as I know he has gotten
"intimate" with these bits of code in the PostgreSQL tree.
-- 
(reverse (concatenate 'string "ofni.secnanifxunil" "@" "enworbbc"))
http://linuxdatabases.info/info/languages.html
Group Dynamics
"Following Minsky and Schelling, consider a person as a society of
agents. A group is then a larger society of such agents. Understand
groups by examining interactions of coalitions of agents that
cross-cut their grouping into people."
-- Mark Miller