On 10/1/07, Jan Wieck <JanWieck at yahoo.com> wrote:
> On 9/30/2007 4:45 PM, Marko Kreen wrote:
> >>    - Removed qsort() wrapper function. Only referenced once.
> >
> > Although I don't object the change, I liked the wrapper function.
> > That way all the is_visible/cmp_txid/sort code was visually
> > close together and easy to get overview.
> >
> > Also the qsort() takes lot of parameters, having it in the middle
> > of a tricky function feels messy.
> >
> > You later mentioned call overhead for called-once static functions,
> > but I think you are incorrect.  Any sane compiler should inline
> > such functions automatically.  Even if not, this is not a hot-path
> > for txid code (txid_is_visible_in_snapshot() is.)
>
> Why not declare it inline?

Because it should no be needed and does not matter much.  But yes,
if possible call overhead annoys you, this is what should be done.

> Good. If I can get Slony actually working with this, I will add it to
> the CVS and we can do the final polishing there.

Ok.  Awaiting your results then.

-- 
marko