Odd, if I download and untar from http://www.slony.info/downloads/1.2/source/slony1-1.2.15.tar.bz2

Under the src/slony_logshipper/scan.l file, I find that the extra "*cp+ 
+ = c;" lines are missing.  There's only once occurrence of the  
command at each of the lines I listed, not two.  There should be two  
at lines lines 175, 191, 244, and 260

--Richard



On Jul 6, 2009, at 11:37 AM, Christopher Browne wrote:

> Richard Yen <dba at richyen.com> writes:
>> Hi guys,
>>
>> I recently ran into an issue with double single-quotes in the
>> logshipping .sql files, and I reviewed my patch from bug #49
>>
>> Looks like the additional "*cp++ = c;" line is missing at lines 175,
>> 191, 244, and 260
>
> The extra "cp++ = c;" lines seems to be there fine in 1.2, 2.0, and
> HEAD, and it is in the tarball for 1.2.5.
>
> -----------------------------------------------------------------------
> RCS file: /home/cvsd/slony1/slony1-engine/src/slony_logshipper/ 
> scan.l,v
> Working file: scan.l
> head: 1.3
> branch:
> locks: strict
> access list:
> symbolic names:
> 	REL_2_0_2: 1.3
> 	REL_1_2_16: 1.1.2.2
> 	REL_2_0_2_RC: 1.3
> 	REL_1_2_16_RC: 1.1.2.2
> 	REL_2_0_1: 1.3
> 	REL_2_0_0: 1.3
> 	REL_2_0_STABLE: 1.3.0.2
> 	REL_2_0_0_RC2: 1.3
> 	REL_1_2_15: 1.1.2.2
> 	REL_2_0_0_RC1: 1.3
> 	REL_1_2_14: 1.1.2.2
> 	REL_1_2_14_RC: 1.1.2.1
> 	REL_1_2_13: 1.1.2.1
> 	REL_1_2_12: 1.1.2.1
> 	REL_1_2_STABLE: 1.1.0.2
> keyword substitution: kv
> total revisions: 5;	selected revisions: 5
> description:
> ----------------------------
> revision 1.3
> date: 2008-05-13 17:41:59 -0400;  author: cbbrowne;  state: Exp;   
> lines: +5 -5
> Per bug #49 - reported by Richard Yen <dba at richyen.com>
>
> Seems like double single-quotes and slashes are begin converted to  
> single
> single-quotes and slashes when not desired:
>
> ERROR 2008-04-24 16:17:32 > PGRES_FATAL_ERROR: ERROR:  syntax error  
> at or near
> "Cahier"
> LINE 1: ..._count, compare_to_database) values ('1969048', ''Cahier  
> d'u...
>                                                            ^
> Query was: insert into "public"."m_object_paper" (id, title,  
> x_firstname,
> x_lastname, char_length, word_count, grade, grade_note, overwriteflag,
> is_indexed, folder, "assignment", "owner", node, page_count,
> compare_to_database) values ('1969048', ''Cahier d'un retour au pays  
> natal' is
> prinicpally defined by violence. Discuss', 'Charlotte', 'Byrne',  
> '10937',
> '1689', NULL, NULL, 't', 'f', '0', '88981', '445800', '2', NULL,
> '1000100000000000000000100000000000101');
> WARN  2008-04-24 16:17:32 > waiting for resume
>
> My fix for this was in scan.l:175
> +                            *cp++ = c;
>                             *cp++ = c;
> +                           len += 2;
> -                           len++;
>
> Similar changes at lines 191, 244, and 260
> ----------------------------
> revision 1.2
> date: 2007-09-08 22:37:05 -0400;  author: wieck;  state: Exp;   
> lines: +582 -0
> Add slony_logshipper to HEAD.
>
> Jan
> ----------------------------
> revision 1.1
> date: 2007-09-08 10:21:40 -0400;  author: wieck;  state: dead;
> branches:  1.1.2;
> file scan.l was initially added on branch REL_1_2_STABLE.
> ----------------------------
> revision 1.1.2.2
> date: 2008-05-13 17:40:28 -0400;  author: cbbrowne;  state: Exp;   
> lines: +5 -5
> Per bug #49 - reported by Richard Yen <dba at richyen.com>
>
> Seems like double single-quotes and slashes are begin converted to  
> single
> single-quotes and slashes when not desired:
>
> ERROR 2008-04-24 16:17:32 > PGRES_FATAL_ERROR: ERROR:  syntax error  
> at or near
> "Cahier"
> LINE 1: ..._count, compare_to_database) values ('1969048', ''Cahier  
> d'u...
>                                                            ^
> Query was: insert into "public"."m_object_paper" (id, title,  
> x_firstname,
> x_lastname, char_length, word_count, grade, grade_note, overwriteflag,
> is_indexed, folder, "assignment", "owner", node, page_count,
> compare_to_database) values ('1969048', ''Cahier d'un retour au pays  
> natal' is
> prinicpally defined by violence. Discuss', 'Charlotte', 'Byrne',  
> '10937',
> '1689', NULL, NULL, 't', 'f', '0', '88981', '445800', '2', NULL,
> '1000100000000000000000100000000000101');
> WARN  2008-04-24 16:17:32 > waiting for resume
>
> My fix for this was in scan.l:175
> +                            *cp++ = c;
> 			     *cp++ = c;
> +                           len += 2;
> -                           len++;
>
> Similar changes at lines 191, 244, and 260
> ----------------------------
> revision 1.1.2.1
> date: 2007-09-08 10:21:40 -0400;  author: wieck;  state: Exp;   
> lines: +580 -0
> Add the slony_logshipper.
>
> This is a standalone utility that can be used with the slon -x option
> to postprocess slony archive log files. Since it does not require any
> changes in the existing slony or slonik functionality, I decided to
> the current stable branch to be released with 1.2.12.
>
> Jan
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
>
> -- 
> (reverse (concatenate 'string "ofni.sailifa.ac" "@" "enworbbc"))
> <http://dba2.int.libertyrms.com/>
> Christopher Browne
> (416) 673-4124 (land)
> "Bother,"  said Pooh,  "Eeyore, ready  two photon  torpedoes  and lock
> phasers on the Heffalump, Piglet, meet me in transporter room three"