"David Rees" <drees76 at gmail.com> writes:
> On Fri, May 16, 2008 at 3:02 PM, David Rees <drees76 at gmail.com> wrote:
>> On Fri, May 16, 2008 at 2:39 PM, Jeff Frost <jeff at frostconsultingllc.com> wrote:
>>> On Fri, 16 May 2008, Christopher Browne wrote:
>>>> Jeff Frost <jeff at frostconsultingllc.com> writes:
>>>>> Hrmmm..I get this when trying to update functions:
>>>>>
>>>>> ./upgrade.slonik:5: Possible unsupported PostgreSQL version 8.3,
>>>>> defaulting to 8.1 support
>
> Looks like there is two places where the versions are checked in
> slonik.c, around like 1900 and around line 2000. The code should
> probably be moved in to a common function, but attached is a quick
> patch to make them match.
>
> At this point the message is completely harmless and only cosmetic.

Right you are!  Happily, the message is, as you say, harmless and
cosmetic.  The code is doing the right things anyways.  I'll see about
patching this (not today; I'm at PGCon) so it appears to behave right,
instead of merely doing so :-).

It is indeed irritating that this code occurs twice; it is essentially
eliminated in v2.0, so I don't think it's worth going to much effort
to do the "big fix."
-- 
"cbbrowne","@","acm.org"
http://cbbrowne.com/info/oses.html
"I still maintain the point that designing a monolithic kernel in 1991
is  a fundamental error.   Be thankful  you are  not my  student.  You
would not get a high grade  for such a design :-)" -- Andrew Tanenbaum
to Linus Torvalds