Christopher Browne cbbrowne at ca.afilias.info
Thu Jun 14 08:40:16 PDT 2007
Devrim GÜNDÜZ <devrim at CommandPrompt.com> writes:
> Hello,
>
> On Wed, 2007-06-13 at 21:59 +0000, Christopher Browne wrote:
>
>> The URL that works:
>> <http://lists.slony.info/downloads/1.2/source/slony1-1.2.10-pre.tar.bz2>
>> 
>
> Thanks. Here are the issues that I found in the tarball:
>
> 1. .cvsignore files:
>
> ./doc/implementation/.cvsignore
> ./doc/concept/.cvsignore
> ./src/ducttape/.cvsignore
> ./src/xxid/.cvsignore
> ./src/slon/.cvsignore
> ./src/slonik/.cvsignore
> ./src/backend/.cvsignore
> ./.cvsignore

I'm inclined to add a rule to "make distclean" to clean this out.

> 2. Unneeded file in the tarball:
>
> ./.#postgresql-slony1-engine.spec.in.1.31.2.6

That seems extremely odd.

cbbrowne at dba2:/opt/OXRS/sources> tar tfvj slony1-1.2.10-pre.tar.bz2 | grep postgres
-rw-r--r-- cbbrowne/users   9151 2007-06-12 21:49 slony1-1.2.10-pre/postgresql-slony1-engine.spec.in
-rwxr-xr-x cbbrowne/users   2749 2007-06-05 18:25 slony1-1.2.10-pre/redhat/postgresql-slony1-engine.init
-rwxr-xr-x cbbrowne/users   8929 2007-06-11 05:54 slony1-1.2.10-pre/redhat/postgresql-slony1-engine.specfile
-rw-r--r-- cbbrowne/users   5518 2005-10-22 16:02 slony1-1.2.10-pre/suse/postgresql-slony1-engine.specfile
cbbrowne at dba2:/opt/OXRS/sources> 

There are all of the files in the tarball that contain the string
'postgres'; the file you're referring to isn't there at all.  That
smells like a file that CVS would leave lying around locally; could
you have extracted the sources into a not-fresh directory?

> 3. Permission issues
>
> There are various permission issues in the tarball. I have reported them
> before. Here is what I currently do in my spec file:
> chmod -R 644 doc/*
>
> I'm currently testing the tarball, will report more (if I can find
> more :) )

I'll look back at Peter Eisentraut's permission complaints, too, and
see about a "make distclean" rule to fix this.

If you see more borken permissions, I'd appreciate if you bounce them
to the list (whether -general or -bugs, I don't care); if I catch the
issues multiple times, that's not a bad thing.
-- 
(reverse (concatenate 'string "ofni.sailifa.ac" "@" "enworbbc"))
<http://dba2.int.libertyrms.com/>
Christopher Browne
(416) 673-4124 (land)


More information about the Slony1-general mailing list