Christopher Browne cbbrowne
Thu Dec 14 08:01:03 PST 2006
Jeff Davis wrote:
> Here is a fix for that. The comment-eating regex was broken because it
> ended with a "$", matching only EOL. I changed it to "#.*" which should
> eat any proper comment. This is the same as postgresql's guc-file.l.
>
>   
OK, that explains where the trouble was; that makes the problem rather
less disturbing :-).
> So, there were two problems with ProcessConfigFile(). The first was that
> the loop would exit when getting an EOF without saving the config
> variable, even if the line was complete but just lacking an EOL. The
> second was that the comment regex only matched comments ending in EOL,
> not EOF.
>   
The patch is working out fine.  Thanks very much.



More information about the Slony1-general mailing list