> -----Original Message-----
> From: Magnus Hagander [mailto:mha at sollentuna.net] 
> Sent: 17 September 2005 14:57
> To: Dave Page; slony1-general at gborg.postgresql.org
> Subject: RE: [Slony1-general] PATCH: Slony win32 service registration
> 
> > > This patch adds service registration and unregistration 
> and enginge 
> > > addition and removal to slon for win32.
> > 
> > Thanks, patch applied.
> > 
> > I think there is an enhancement that should be made however - 
> > at present, when you install the service it actually installs 
> > in a state in which it won't start because no engines have 
> > been registered. Perhaps it should install in 'Disabled' 
> > startup mode, which is then set to 'Automatic' when the first 
> > engine is registered. When removing the last engine, it can 
> > be set back to 'Disabled'.
> 
> I don't like this at all. Once we have installed, we should not modify
> the service configuration because what we do may conflict 
> with something
> the user did manually. (Say he set it to Manual, then he 
> registers a new
> engine, and pop it's in automatic again. Personally I absolutely hate
> tools that do that..)

Good point.

> > Otherwise, on reboot the (potentially scary!) 'A service or 
> > device driver failed at startup - see the system event log 
> > for details' error will likely be displayed.
> > 
> > Thoughts?
> 
> I see the problem. Another solution to this would be to have 
> Slon start
> up (and not crash!) and just log a warning in the eventlog if 
> it has no
> configured engines? Because something *is* wrong, but we'd 
> show it in a
> less scary fashion... Reasonable?

Yeah, that sounds good. It would probably be useful to log the startup &
shutdown of each engine anyway so it's easy to see what starts and
stops. For that matter, adding or removing an engine should also cause
it to startup or shutdown, or at least output a message telling the user
to restart the service.

Regards, Dave.