Christopher Browne cbbrowne
Mon Mar 21 16:27:05 PST 2005
Andreas Pflug wrote:

> I got some minutes to test CVS HEAD under win32 mingw, and the result 
> is unfortunately a regression from what 1.05 gives.
>
> ./configure will fail because it checks for sigaction, which is used 
> in slon.c for SIGHUP handling. win32 doesn't provide sigaction(), only 
> signal() which is probably sufficient for win32 anyway. Maybe 
> configure can implement a fallback to signal() if sigaction() isn't 
> present?
>
Maybe; I have evaded knowledge of configure thus far, deferring this to 
Darcy.  Darcy, does this seem sensible to you?

There is only one reference to sigaction(), that in slon.c, so I would 
hope this wouldn't be too difficult to deal with...

> After this configure error, I don't get Makefiles so I couldn't 
> execute more tests. Still, I have some information to share.
>
> In schedule.c and slon.c, pthread_self() result is compared with a 
> pthread_t variable, which isn't the recommended way to check for 
> equality; instead pthread_equal should be used. Under win32 this 
> fails, because pthread_t isn't a simple value. The attached file 
> provides a patch for this, and should make this portable for all 
> pthread_t platforms.

This change seems good; I'm trying it out on AIX as well, to get some 
further testing in.

> The backend/xxid makefiles I provided some time ago (now located in 
> the Win32 subdirectory) were meant as portable replacement for the 
> current versions for *all* platforms, not only mingw. They don't need 
> ./configure to be created (just as typical pgsql/contrib makefiles). 
> They work successfully on Linux, and I would expect them to do so on 
> any pgsql supported platform.

These don't seem to replace the existing makefiles; are they supposed to 
just replace certain parts of the existing ones?


More information about the Slony1-general mailing list