Jacob Coby jcoby
Wed Jun 29 15:13:58 PDT 2005
Hiroshi Saito wrote:
> Thanks all.:-)
> As for me, a response is slow..
> 
> It is the first part.

> +#ifndef WIN32
> +       strcpy(m_pgshare, PGSHARE);
> +#else
> +       /* This begins to look for share. */
> +       strcpy(m_pgshare, get_sharepath(argv[0]));
> +#endif

You have a small memory leak here since get_sharepath malloc()s the 
result, but is never free()d.  My C is rusty, but I think you should 
pass in the char *pgshare plus a size_t size to fill with the sharepath.

The m_ prefix seems out of place in the slony source as well.

-- 
-Jacob


More information about the Slony1-general mailing list