On Monday 18 July 2005 14:42, Dave Page wrote:
> > -----Original Message-----
> > From: slony1-general-bounces at gborg.postgresql.org
> > [mailto:slony1-general-bounces at gborg.postgresql.org] On
> > Behalf Of Dave Page
> > Sent: 18 July 2005 20:28
> > To: Darcy Buskermolen; slony1-general at gborg.postgresql.org
> > Subject: RE: [Slony1-general] [PATCH] slon win32
> >
> > > My only comment re this patch is, I think we had discuses
> > > putting the OS
> > > specific stuff (pipe.c) in it's own directory ie src/port,
> > > following the PG
> > > convention.
> >
> > Yes, I remember that discussion. I'll adjust the patch accordingly
> > before committing.
>
> I've been looking at this, and it actually becomes quite messy for what
> is almost certainly going to be a pretty small amount of port specific
> code. It seems to me that a much cleaner way is to simply include a
> slon/port directory, and include the port specific stuff there (per PGs
> src/backend/port directory). The attached version of Magnus' patch does
> exactly that, with port/pipe.c built directly from slon/Makefile.
>
> Any thoughts/objections?

That's fine in my books.
>
> Regards, Dave.

-- 
Darcy Buskermolen
Wavefire Technologies Corp.

http://www.wavefire.com
ph: 250.717.0200
fx: 250.763.1759