Christopher Browne cbbrowne
Mon Apr 11 18:13:15 PDT 2005
Darcy Buskermolen wrote:

>
>>Another thing I noticed today is the slonik function "UPDATE FUNCTIONS".
>>If you are running PostgreSQL 8.x.x then it doesn't work. There are
>>no separate 8.0 slony1_funcs scripts yet etc etc.
>>    
>>
>
>These need to be added to allow for proper handling of slon_quote_ident.
>
>We use our version on < 8.0.2 . for 8.0.2 + we just have a wrapper of return 
>pg_catalog.quote_ident($1); (have a look at slonik/db_utils.[ch] for proper 
>handling)
>  
>
Who's "on the hook" for this one?  I'm fine with holding off a day or so 
if we need to; that gives me time to prepare release notes and maybe 
even an extra test or two.

But the item of getting the < 8.0.2 integration in place needs to be a 
high priority somewhere, as it's "burning past" the freeze date...

I presume this means doing the following:

1.  Adding a script slony1_funcs_v802.sql with the thin wrapper on 
pg_catalog.quote_indent

2.  Adding the "legacy" function that is the alternative to #1 to 
slony1_funcs_v74.sql and slony1_funcs.v73.sql

3.  Adding to the src/slonik/slonik.c logic to load 
slony1_funcs_v802.sql if version >= 8.0.2


More information about the Slony1-general mailing list