Update of /home/cvsd/slony1/slony1-engine/tools/altperl
In directory main.slony.info:/tmp/cvs-serv29454

Modified Files:
	slon-tools.pm 
Log Message:
Per bug #38 - reported by Peter Eisentraut

The way the function start_slon in slon-tools.pm assembles the command line
creates a command that looks like this:

slon ... 2>&1 >logfile &

This ends up dumping the error messages on the console (or wherever) and only
stdout to the log file.  What you want is this:

slon ... >logfile 2>&1 &

The patch fixes this.


Index: slon-tools.pm
===================================================================
RCS file: /home/cvsd/slony1/slony1-engine/tools/altperl/slon-tools.pm,v
retrieving revision 1.31
retrieving revision 1.32
diff -C2 -d -r1.31 -r1.32
*** slon-tools.pm	21 Mar 2007 15:11:12 -0000	1.31
--- slon-tools.pm	6 Mar 2008 19:21:31 -0000	1.32
***************
*** 134,144 ****
    $SYNC_CHECK_INTERVAL ||= 1000;
    system("mkdir -p $LOGDIR/slony1/node$nodenum");
!   my $cmd = "@@SLONBINDIR@@/slon -s $SYNC_CHECK_INTERVAL -d$DEBUGLEVEL $CLUSTER_NAME '$dsn' 2>&1 ";
    if ($APACHE_ROTATOR) {
!     $cmd .= "| $APACHE_ROTATOR \"$LOGDIR/slony1/node$nodenum/" .  $dbname . "_%Y-%m-%d_%H:%M:%S.log\" 10M &";
    } else {
      my $now=`date '+%Y-%m-%d_%H:%M:%S'`;
      chomp $now;
!     $cmd .= "> $LOGDIR/slony1/node$nodenum/$dbname-$now.log &";
    }
    print "Invoke slon for node $nodenum - $cmd\n";
--- 134,144 ----
    $SYNC_CHECK_INTERVAL ||= 1000;
    system("mkdir -p $LOGDIR/slony1/node$nodenum");
!   my $cmd = "@@SLONBINDIR@@/slon -s $SYNC_CHECK_INTERVAL -d$DEBUGLEVEL $CLUSTER_NAME '$dsn' ";
    if ($APACHE_ROTATOR) {
!     $cmd .= "2>&1 | $APACHE_ROTATOR \"$LOGDIR/slony1/node$nodenum/" .  $dbname . "_%Y-%m-%d_%H:%M:%S.log\" 10M &";
    } else {
      my $now=`date '+%Y-%m-%d_%H:%M:%S'`;
      chomp $now;
!     $cmd .= "> $LOGDIR/slony1/node$nodenum/$dbname-$now.log 2>&1 &";
    }
    print "Invoke slon for node $nodenum - $cmd\n";