bugzilla-daemon at main.slony.info bugzilla-daemon at main.slony.info
Thu Sep 18 12:06:47 PDT 2014
http://www.slony.info/bugzilla/show_bug.cgi?id=349

--- Comment #3 from Christopher Browne <cbbrowne at ca.afilias.info> 2014-09-18 12:06:46 PDT ---
Created an attachment (id=204)
 --> (http://www.slony.info/bugzilla/attachment.cgi?id=204)
Quote the namespace

OK, this is pretty clearly a reference to the query in
src/backend/slony1_funcs.c:

            snprintf(query,1023,"select %s.sequenceSetValue($1,"    \
                     "$2,NULL,$3,true); ",tg->tg_trigger->tgargs[0]);    

I can put quotes around it; that should rectify the issue.  It's worth a test
at your end, if you can.

A quick regression test run, with the attached patch, against HEAD, behaves
perfectly well, albeit a test without any entertaining capitalization of
namespaces.

I'm a bit surprised that we have had a regression in this area, as there is a
regression test that tries out having tables and sequences with
StudlyCapitalizedNames and such.  The "testschemanames" works fine, with the
change, but it was working fine without.

I should have expected that test to catch this.  

Or not; this seems to be happening as part of DDL processing, so definitely a
more obscure case...

So it looks like adding a regression test requires doing DDL, does that seem
right?

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the Slony1-bugs mailing list