http://www.slony.info/bugzilla/show_bug.cgi?id=208

Christopher Browne <cbbrowne at ca.afilias.info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|slony1-bugs at lists.slony.inf |ssinger at ca.afilias.info
                   |o                           |
             Status|NEW                         |ASSIGNED

--- Comment #2 from Christopher Browne <cbbrowne at ca.afilias.info> 2011-05-25 11:20:23 PDT ---
I reviewed the patch, and the intent looks good.

1 - Make sure sl_event_lock is obtained before searching the schema for the
table.

Yep, that's a good change.

2 - Uses the id value queried if none was provided in the command

Yep.

3 - Fixing misplaced bracket in malloc() call.

Yep, seems right.

It would be nice if there was one of the regression tests that specifically
exercised this; to that end, I took the patch, generated branch "bug208", and
added a would-be regression test to "test1" which introduces tables x1, x2, and
x3, which are to be added via the slonik code you suggest below.

Unfortunately, these tables aren't actually getting added in, so I suspect that
there's some wrinkle I'm missing.

Here's a link to my patch...

https://github.com/cbbrowne/slony1-engine/commit/7d7dfaeb940053951fb6e719370d696d8bfb7bf5

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.