Tue May 10 11:54:06 PDT 2011
- Previous message: [Slony1-bugs] [Bug 207] create set in a try block rollsback
- Next message: [Slony1-bugs] [Bug 207] create set in a try block rollsback
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
http://www.slony.info/bugzilla/show_bug.cgi?id=207 --- Comment #2 from Christopher Browne <cbbrowne at ca.afilias.info> 2011-05-10 11:54:06 PDT --- Some questions... 1. Is there an existing test that moves from "broken" to "working" as a result of this patch? 'Twould be really nice to have such. 2. I'm not thrilled with the complications that this adds, particularly when they're not named much. Quite a bit of indirection involved. I added comments to slonik_wait_config_caughtup() to indicate interpretation of its return results, which better indicates why the change is needful. 3. I noticed a number of references to [64] as the length of names. This is correct, but not descriptive. Postgres has a #define for NAMEDATALEN to indicate this; I have adopted and applied that. It compiles, and looks reasonable, but I haven't tested it. -- Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
- Previous message: [Slony1-bugs] [Bug 207] create set in a try block rollsback
- Next message: [Slony1-bugs] [Bug 207] create set in a try block rollsback
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the Slony1-bugs mailing list