http://www.slony.info/bugzilla/show_bug.cgi?id=217

--- Comment #17 from Steve Singer <ssinger at ca.afilias.info> 2011-06-10 06:39:39 PDT ---
Created an attachment (id=108)
 --> (http://www.slony.info/bugzilla/attachment.cgi?id=108)
replace C function to decode trigger arguments with string matching

This patch to be appplied ontop of the others will remove the C function that
decodes the trigger arguments and replaces it with string matching code against
information_schema.triggers.

I feel that the C function is cleaner and more future proof.  To get this patch
to work I had to be careful about matching spaces and quotes in the function
with the format the information schema returns.  I have not yet done a lot of
testing and suspect that this version of the patch might break with mixed case
slony clusternames (if so that should be fixable).

The C function works and should continue to work with future postgres versions
because it uses the same infrastructure to decode tgargs as postgersql uses
when it invokes the trigger.  With the string matching approach we are
depending on a unit test to tell us that something suttle has changed in
postgresql after the fact.

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.