bugzilla-daemon at main.slony.info bugzilla-daemon at main.slony.info
Thu Jan 20 13:23:32 PST 2011
http://www.slony.info/bugzilla/show_bug.cgi?id=192

           Summary: Cluster test output not specific enough
           Product: Slony-I
           Version: devel
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: low
         Component: other scripts
        AssignedTo: slony1-bugs at lists.slony.info
        ReportedBy: cbbrowne at ca.afilias.info
                CC: slony1-bugs at lists.slony.info
   Estimated Hours: 0.0


I excerpt sample output from a run of the "Empty Set" test:

pass,slonik exit status
pass,slonik exit status
pass,slonik exit status
pass,slonik exit status
pass,slonik exit status
pass,second set created okay
pass,merging unsubscribed set caused an error
pass,merging empty set
pass,slonik exit status

This has several tests which pass with exactly the same string as output (e.g.
- the first 5 lines are identical).

If I do some re-parsing (e.g. - as to generate results to summarize and report
on this as part of some regular regression test), the "tuples" aren't unique so
as to allow me to reference them.  In effect, there's no "primary key" on this
:-).

I see two resolutions, both of which likely have some proper involvement:

a) The calls to assertCheck() should be passing more meaningful output, so that
they are not all merely "slonik exit status"

https://github.com/cbbrowne/slony1-engine/commit/69c7b2d4418c7741bbd0c3c10167a8f865e3ce60

b) assertCheck() should be modified to add a 3rd column that is a surrogate for
a primary key, e.g., a sequential value?

I have committed this to master; that is perhaps arguable...

https://github.com/clustertest/clustertest-framework/commit/bd8bce581c46281864c3cc62fa65dddb75f98360

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Slony1-bugs mailing list