Do I have to open bugs for these errors ?

Cyril Scetbon wrote:
> The error comes from the following code :
>
> if (find_my_exec(argv[0],myfull_path) < 0)
> {
>    strcpy(share_path, PGSHARE);
> }
> else
> {
>    get_share_path(myfull_path, share_path);
> }
>
> that is if I use "slonik_init_cluster|/usr/bin/slonik" or 
> "slonik_init_cluster|slonik" it finds the exec file and does not use 
> PGSHARE as a share_path for slony1xxx.sql file. It should not use 
> get_share_path if PGSHARE is defined !
>
> to remember the issue : I compile slonik with 
> -DPGSHARE="\"/usr/share/slony1\"" but slonik searches for 
> slony1_base.sql (and other files) in /usr/share/postgresql/8.3/ and 
> not in PGSHARE
>
> Regards
>
> Cyril Scetbon wrote:
>> Hi guys,
>>
>> you should
>>
>> - change SLONY_I_VERSION_STRING in config.h to reflect the current 
>> version
>> - update tools/altperl/slon-tools.pm cause you're using 2 different 
>> variables (in start_slon function) for the log level as you can see 
>> in the current version :
>>
>>  $DEBUG_INTERVAL ||= 0;
>>  system("mkdir -p $LOGDIR/slony1/node$nodenum");
>>  my $cmd = "@@SLONBINDIR@@/slon -s $SYNC_CHECK_INTERVAL -d$DEBUGLEVEL 
>> $CLUSTER_NAME '$dsn' ";
>>
>> ==> (correct version)
>>
>>  $DEBUGLEVEL ||= 0;
>>  system("mkdir -p $LOGDIR/slony1/node$nodenum");
>>  my $cmd = "@@SLONBINDIR@@/slon -s $SYNC_CHECK_INTERVAL -d$DEBUGLEVEL 
>> $CLUSTER_NAME '$dsn' ";
>>
>> besides this, I met an issue with slonik that is trying to load the 
>> file :
>>
>> <stdin>:6: could not open file /usr/share/postgresql/8.3/slony1_base.sql
>>
>> however slonik is compiled with -DPGSHARE="\"/usr/share/slony1\"" as 
>> you can see below :
>>
>> make[3]: Entering directory 
>> `/home/cscetbon/packaging/slony1-2.0.1/src/slonik'
>> cc -g -Wall -O2 -Wall -Wmissing-prototypes -Wmissing-declarations 
>> -I../.. -DPGSHARE="\"/usr/share/slony1\""  -I/usr/include/postgresql/ 
>> -I/usr/include/postg
>> resql/8.3/server/  -c -o slonik.o slonik.c
>> cc -g -Wall -O2 -Wall -Wmissing-prototypes -Wmissing-declarations 
>> -I../.. -DPGSHARE="\"/usr/share/slony1\""  -I/usr/include/postgresql/ 
>> -I/usr/include/postgresql/8.3/server/  -c -o dbutil.o dbutil.c
>> cc -g -Wall -O2 -Wall -Wmissing-prototypes -Wmissing-declarations 
>> -I../.. -DPGSHARE="\"/usr/share/slony1\""  -I/usr/include/postgresql/ 
>> -I/usr/include/postgresql/8.3/server/  -c -o parser.o parser.c
>> In file included from parser.y:1879:
>> scan.c:2293: warning: no previous prototype for 'yyget_lineno'
>> scan.c:2302: warning: no previous prototype for 'yyget_in'
>> scan.c:2310: warning: no previous prototype for 'yyget_out'
>> scan.c:2318: warning: no previous prototype for 'yyget_leng'
>> scan.c:2327: warning: no previous prototype for 'yyget_text'
>> scan.c:2336: warning: no previous prototype for 'yyset_lineno'
>> scan.c:2348: warning: no previous prototype for 'yyset_in'
>> scan.c:2353: warning: no previous prototype for 'yyset_out'
>> scan.c:2358: warning: no previous prototype for 'yyget_debug'
>> scan.c:2363: warning: no previous prototype for 'yyset_debug'
>> scan.c:2400: warning: no previous prototype for 'yylex_destroy'
>> cc -g -Wall -O2 -Wall -Wmissing-prototypes -Wmissing-declarations 
>> -I../.. -DPGSHARE="\"/usr/share/slony1\""  slonik.o dbutil.o 
>> parser.o  ../parsestatements/
>> scanner.o -L/usr/lib/ -L/usr/lib/postgresql/8.3/lib -lpq  
>> -Wl,-rpath,/usr/lib/ -lpgport -o slonik
>>
>> why does it chooses to load slony1_base.sql from 
>> /usr/share/postgresql/8.3/ ?
>>
>> Regards
>

-- 
Cyril SCETBON