On Feb 19, 2008 2:14 PM, Peter Eisentraut <peter_e at gmx.net> wrote:
> Am Dienstag, 19. Februar 2008 schrieb Dave Page:
> > So what are we expecting to happen?
>
> The only thing in the Slony installation that needs to depend on PostgreSQL
> parameters at all is the installation location of xxid.so and
> slony1_funcs.so.  That is properly detected using pg_config.  Everything else
> should just use the standard configure parameters such as --bindir
> and --datadir, freely chosen by the user.

Right, but those can change between build and runtime which is the
problem I face.

To add to the complication, Chris has removed a change I made to
include libpgport on *nix which it seems doesn't contain the required
functions on 7.4 (get_share_path and friends). Copying all of that lot
into slonik seems somewhat excessive.

So, how about we use a simple search to find the share directory. The
first location in which we can read slony1_funcs.sql wins:

Where $BINDIR is the directory part of argv[0], we search:

$BINDIR/../share/
$BINDIR/../slony/share/
$BINDIR/../postgresql/share/
$PGSHAREDIR/ (as defined at Slony build time, per old Unix behaviour)

Thoughts?

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Oracle-compatible database company