| Summary: | New 8.4 #include - utils/snapmgr.h | ||
|---|---|---|---|
| Product: | Slony-I | Reporter: | Christopher Browne <cbbrowne> |
| Component: | trigger SPI | Assignee: | Slony Bugs List <slony1-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | slony1-bugs |
| Priority: | low | ||
| Version: | 1.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://lists.slony.info/pipermail/slony1-hackers/2008-March/000134.html | ||
| Attachments: |
Patch to add reference to new #include of utils/snapmgr.h in 8.4
Newer patch to Slony-I to run against 8.4 - uses new GetActiveSnapshot() function |
||
Note: this issue observed by: (quoted-printable J=C3=B8rgen Austvik) <jorgen.austvik@sun.com> Work: +47 73 84 21 10 Senior Engineer Fax: +47 73 84 21 01 Sun Microsystems Database Technology Group Haakon VII gt. 7b Trondheim, NO-7485 Norway According to the following patch that is likely to be applied... http://archives.postgresql.org/pgsql-patches/2008-04/msg00425.php SerializableSnapshot, as global symbols, are no more. This will require a further change to slony1_funcs.c Note that the change to src/xxid/xxid.c is unnecessary as the whole src/xxid/xxid.c "tree" has been eliminated from CVS HEAD as equivalent functionality is in the PostgreSQL core in v8.3+. Created attachment 22 [details]
Newer patch to Slony-I to run against 8.4 - uses new GetActiveSnapshot() function
Attached is a newer patch.
This needs to be modified somewhat to address the fact that 8.3 expects the former form, and 8.4 expects the new form. I'll discuss that on-list.
Resolved in the CVS commit that involved the following... http://lists.slony.info/pipermail/slony1-commit/2008-September/002366.html - Autoconf detects whether or not the new function is available - If it is, config.h.in defines a preprocessor variable - If that variable is defined, slony1_funcs.c uses the new function |
Created attachment 13 [details] Patch to add reference to new #include of utils/snapmgr.h in 8.4 The attached patch fixes a compile problem on at least Solaris and Linux against PostgreSQL HEAD from CVS. It will need further work so that we only do this #include for 8.4 and later versions, and leave it out from earlier PG releases.