Bug 46 - New 8.4 #include - utils/snapmgr.h
Summary: New 8.4 #include - utils/snapmgr.h
Status: RESOLVED FIXED
Alias: None
Product: Slony-I
Classification: Unclassified
Component: trigger SPI (show other bugs)
Version: 1.2
Hardware: All All
: low normal
Assignee: Slony Bugs List
URL: http://lists.slony.info/pipermail/slo...
Depends on:
Blocks:
 
Reported: 2008-03-28 08:24 UTC by Christopher Browne
Modified: 2008-09-24 12:56 UTC (History)
1 user (show)

See Also:


Attachments
Patch to add reference to new #include of utils/snapmgr.h in 8.4 (2.33 KB, patch)
2008-03-28 08:24 UTC, Christopher Browne
Details
Newer patch to Slony-I to run against 8.4 - uses new GetActiveSnapshot() function (890 bytes, patch)
2008-09-24 11:57 UTC, Christopher Browne
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Browne 2008-03-28 08:24:51 UTC
Created attachment 13 [details]
Patch to add reference to new #include of utils/snapmgr.h in 8.4

The attached patch fixes a compile problem on at least Solaris and
Linux against PostgreSQL HEAD from CVS.

It will need further work so that we only do this #include for 8.4 and later versions, and leave it out from earlier PG releases.
Comment 1 Christopher Browne 2008-03-28 08:25:35 UTC
Note: this issue observed by:

(quoted-printable J=C3=B8rgen Austvik) <jorgen.austvik@sun.com>     Work: +47 73 84 21 10 
Senior Engineer                                                     Fax:  +47 73 84 21 01
Sun Microsystems
Database Technology Group
Haakon VII gt. 7b
Trondheim, NO-7485 Norway
Comment 2 Christopher Browne 2008-04-22 13:31:36 UTC
According to the following patch that is likely to be applied...

http://archives.postgresql.org/pgsql-patches/2008-04/msg00425.php

SerializableSnapshot, as global symbols, are no more.  This will require a further change to slony1_funcs.c

Note that the change to src/xxid/xxid.c is unnecessary as the whole src/xxid/xxid.c "tree" has been eliminated from CVS HEAD as equivalent functionality is in the PostgreSQL core in v8.3+.
Comment 3 Christopher Browne 2008-09-24 11:57:00 UTC
Created attachment 22 [details]
Newer patch to Slony-I to run against 8.4 - uses new GetActiveSnapshot() function

Attached is a newer patch.

This needs to be modified somewhat to address the fact that 8.3 expects the former form, and 8.4 expects the new form.  I'll discuss that on-list.
Comment 4 Christopher Browne 2008-09-24 12:56:32 UTC
Resolved in the CVS commit that involved the following...

http://lists.slony.info/pipermail/slony1-commit/2008-September/002366.html

- Autoconf detects whether or not the new function is available
- If it is, config.h.in defines a preprocessor variable
- If that variable is defined, slony1_funcs.c uses the new function